Skip to content

Conversation

@fiedlr
Copy link
Contributor

@fiedlr fiedlr commented Aug 29, 2025

risk: nonprod

For CR

  • basic functionality works
  • missing tests for precedence and clone_workspace
    • the clone_workspace test works but is commented out for reasons mentioned in TODO
  • CatalogDataset implementation might be needed to be fixed, see the TODO comment
  • consider regenerating all cassettes. the suite is a bit flaky so this might take some time

@fiedlr fiedlr marked this pull request as draft August 29, 2025 09:19
@fiedlr fiedlr force-pushed the afi-cq-1236-new-preagg-dataset-endpoints-2 branch from 8cdd38d to 134dc7c Compare August 29, 2025 11:43
@fiedlr fiedlr marked this pull request as ready for review August 29, 2025 13:35
@fiedlr fiedlr force-pushed the afi-cq-1236-new-preagg-dataset-endpoints-2 branch from 1cf0d22 to 06fb724 Compare August 29, 2025 14:24
@fiedlr fiedlr force-pushed the afi-cq-1236-new-preagg-dataset-endpoints-2 branch from 06fb724 to 04c31f0 Compare August 29, 2025 14:29
fiedlr added 4 commits August 29, 2025 17:07
- test isn't changed for now

risk: nonprod
risk: nonprod
@fiedlr fiedlr enabled auto-merge August 31, 2025 12:09
@fiedlr fiedlr merged commit c131be2 into gooddata:master Sep 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants