Make chexify docstring test robust to platform-specific tracebacks#420
Open
pandaayushman wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Make chexify docstring test robust to platform-specific tracebacks#420pandaayushman wants to merge 1 commit intogoogle-deepmind:mainfrom
pandaayushman wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
hbq1
approved these changes
Jan 6, 2026
hbq1
reviewed
Jan 6, 2026
|
|
||
| # On Windows, JAX traceback filtering drops the user-frame filename. | ||
| expected_regex = ( | ||
| err_regex if sys.platform == "win32" |
Member
There was a problem hiding this comment.
please update the quote delimiters to fix the CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JAX chexify traceback filtering can drop user-frame filenames on windows, causing test_docstring_example to fail due to filename dependent regex. This change relaxes the test assertion to account for platform specific traceback nature while preserving verification that the right chexify assertion is raised.