Conversation
jhansitavva
force-pushed
the
main-edge-to-edge
branch
from
200f690 to
7bc0578
Compare
jhansitavva
force-pushed
the
main-edge-to-edge
branch
from
7bc0578 to
812e82d
Compare
johnshea
left a comment
johnshea
left a comment
There was a problem hiding this comment.
Update gradle wrapper to latest version. Currently 8.2
Update kotlinCompilerExtensionVersion to the latest.
Update BOM to the latest.
Project build.gradle.kts - Update all plugins to the latest versions
Type.kt - ln 31 - insert blank line to push comment down
Type.kt - ln 33 & ln 41 - remove blank lines for consistency
There was a problem hiding this comment.
Should the MaterialTheme shape value be used here?
There was a problem hiding this comment.
Yes, this was already reviewed by SMEs
There was a problem hiding this comment.
There are multiple occurences of 72.dp and 8.dp.
Can these be moved to the dimens.xml?
There was a problem hiding this comment.
There is no dimens.xml for this project.
johnshea
left a comment
johnshea
left a comment
There was a problem hiding this comment.
One nit - build.gradle.kts - You updated to a newer version but didn't update to the latest one.
5 participants
This is the reference PR from Meghan: Woof edge to edge
Changes in this PR:
I would appreciate it if you could take a look at these changes and let me know.