Skip to content

Fix bug in 'Experiment with other animations' #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasv18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug in 'Experiment with other animations' #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion app/src/main/java/com/example/woof/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.annotation.DrawableRes
import androidx.annotation.StringRes
import androidx.compose.animation.animateColorAsState
import androidx.compose.animation.animateContentSize
import androidx.compose.animation.core.Spring
import androidx.compose.animation.core.spring
Expand All @@ -38,6 +39,7 @@ import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.ExpandLess
import androidx.compose.material.icons.filled.ExpandMore
import androidx.compose.material3.Card
import androidx.compose.material3.CardDefaults
import androidx.compose.material3.CenterAlignedTopAppBar
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
Expand Down Expand Up @@ -111,8 +113,14 @@ fun DogItem(
modifier: Modifier = Modifier
) {
var expanded by remember { mutableStateOf(false) }
val color by animateColorAsState(
targetValue = if (expanded) MaterialTheme.colorScheme.tertiaryContainer else MaterialTheme.colorScheme.primaryContainer
)
Card(
modifier = modifier
modifier = modifier,
colors = CardDefaults.cardColors(
containerColor = color
)
) {
Column(
modifier = Modifier
Expand All @@ -122,6 +130,13 @@ fun DogItem(
stiffness = Spring.StiffnessMedium
)
)
// .background(color = color)
// 7. (Optional) Experiment with other animations
// This is a case where placing color in the composable column causes the parent
// card color to appear when the expanded variable is false and
// the Dog Hobby composable disappears leaving a colored background. So to solve it,
// put the animated color on the container color card.

) {
Row(
modifier = Modifier
Expand Down