-
Notifications
You must be signed in to change notification settings - Fork 10.4k
fix(patch): cherry-pick 3f5f030 to release/v0.20.0-pr-14843 to patch version v0.20.0 and create version 0.20.1 #15002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an important enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -17 B (0%) Total Size: 21.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a patch to allow the IdeClient to use an authentication token from the GEMINI_CLI_IDE_AUTH_TOKEN environment variable as a fallback if it's not available in the IDE connection configuration file. However, this change introduces a high-severity security vulnerability. Storing the IDE authentication token in an environment variable risks exposing secrets, as an attacker with local access could steal the token, potentially leading to unauthorized file modifications and code execution. It is strongly recommended to avoid using environment variables for sensitive secrets.
| this.authToken = | ||
| this.connectionConfig?.authToken ?? | ||
| process.env['GEMINI_CLI_IDE_AUTH_TOKEN']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction of reading the authentication token from the GEMINI_CLI_IDE_AUTH_TOKEN environment variable creates a security risk. Storing secrets in environment variables can expose them to other processes, potentially leading to token theft. A compromised token would allow an attacker to modify files in the workspace, creating a path to arbitrary code execution. It is strongly recommended to avoid using environment variables for sensitive data.
This PR automatically cherry-picks commit 3f5f030 to patch version v0.20.0 in the stable release to create version 0.20.1.