-
Notifications
You must be signed in to change notification settings - Fork 10.4k
fix(patch): cherry-pick a6d1245 to release/v0.21.1-pr-15214 to patch version v0.21.1 and create version 0.21.2 #15227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an important refinement to the application's configuration management, specifically concerning how AI models are handled when toggling preview features. The update ensures a more intuitive user experience by automatically selecting the appropriate preview-enabled auto model when preview features are activated, thereby maintaining consistency in model selection and streamlining feature adoption. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +160 B (0%) Total Size: 21.6 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cherry-picks a fix for model switching logic related to preview features. The changes in setPreviewFeatures correctly handle switching to the preview auto model when preview features are enabled, and back to the default auto model when disabled. A new test case has been added to cover this new logic. Additionally, a potential race condition in refreshAuth has been fixed by using the getter for previewFeatures to ensure the latest value is read. The changes are sound and improve the robustness of the configuration management. I have no concerns with this patch.
This PR automatically cherry-picks commit a6d1245 to patch version v0.21.1 in the stable release to create version 0.21.2.