Skip to content

Conversation

@Ashwinhegde19
Copy link

Summary

Fixes a typo in the MIGRATION_MAP that caused the V1 setting loadMemoryFromIncludeDirectories to be migrated to a non-existent V2 path.

Problem

The migration mapped:

  • loadMemoryFromIncludeDirectoriescontext.loadFromIncludeDirectories

But the correct V2 schema key is:

  • context.loadMemoryFromIncludeDirectories

This caused the setting to be silently ignored, breaking GEMINI.md file discovery for users who had this enabled.

Solution

  • Fixed the typo in MIGRATION_MAP (line 115 of settings.ts)
  • Added a test case to prevent regression

Fixes #15069

…ries

Fixes google-gemini#15069

The MIGRATION_MAP was incorrectly mapping 'loadMemoryFromIncludeDirectories'
to 'context.loadFromIncludeDirectories' instead of
'context.loadMemoryFromIncludeDirectories'.

This caused the V1 setting to be silently ignored during migration,
resulting in GEMINI.md files not being loaded from include directories.
@Ashwinhegde19 Ashwinhegde19 requested a review from a team as a code owner December 22, 2025 19:30
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ashwinhegde19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical configuration migration issue where a typo in the MIGRATION_MAP caused the V1 setting loadMemoryFromIncludeDirectories to be incorrectly mapped to a non-existent V2 path. This oversight led to the setting being silently ignored, which in turn prevented proper GEMINI.md file discovery for users who had this feature enabled. The fix corrects this mapping and includes a new test to ensure the migration functions as expected, restoring intended functionality for affected users.

Highlights

  • Typo Fix in Migration Map: Corrected a typo in the MIGRATION_MAP for the loadMemoryFromIncludeDirectories setting, ensuring it now correctly migrates from its V1 path to context.loadMemoryFromIncludeDirectories in V2.
  • New Test Case Added: A new test case was introduced in settings.test.ts to specifically verify the correct migration of the loadMemoryFromIncludeDirectories setting, preventing future regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a typo in the V1 to V2 settings migration map for loadMemoryFromIncludeDirectories. The change ensures that this setting is no longer silently ignored. The addition of a specific test case is excellent, as it prevents future regressions for this migration path. The changes are clear, concise, and effectively resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Migration map typo for loadMemoryFromIncludeDirectories causes setting to be silently ignored

1 participant