-
Notifications
You must be signed in to change notification settings - Fork 10.2k
feat: Show snowfall animation for holiday theme #15494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Gemini CLI with a "Happy Holiday" feature, displaying a dynamic snow animation and holiday tree ASCII art in the header. This seasonal embellishment activates automatically during December and January, provided the user has selected the "Holiday" theme, the terminal window is wide enough, and no chat conversation is in progress. The change aims to bring a festive touch to the user experience during the holiday season. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
This is awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a holiday-themed snow animation. My review focuses on a logic bug in date checking, issues with the new tests that will cause them to fail, and a performance concern in the animation rendering loop. These issues are of high severity and should be addressed to ensure the feature works correctly and efficiently.
|
Size Change: +3.76 kB (+0.02%) Total Size: 22 MB
ℹ️ View Unchanged
|
…op the animation after user enters a text
4370c48 to
239139f
Compare
ff5484e to
cd6983b
Compare
|
/patch both |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
Summary
Show Holiday snow animation
Details
When launched, show snow falling animation when user is using holiday theme.
Shows the snow animation if all of the following requirements are met
Related Issues
How to Validate
Pre-Merge Checklist