Skip to content

Conversation

@sehoon38
Copy link
Collaborator

@sehoon38 sehoon38 commented Dec 23, 2025

Summary

Show Holiday snow animation

Details

When launched, show snow falling animation when user is using holiday theme.
Shows the snow animation if all of the following requirements are met

  • is holiday season (December or January)
  • the current theme is Holiday
  • terminal width is at least the width of Gemini short logo
  • user has not started a chat (excluding /theme command)
  • has not been 15 sec since the animation started

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Gemini CLI with a "Happy Holiday" feature, displaying a dynamic snow animation and holiday tree ASCII art in the header. This seasonal embellishment activates automatically during December and January, provided the user has selected the "Holiday" theme, the terminal window is wide enough, and no chat conversation is in progress. The change aims to bring a festive touch to the user experience during the holiday season.

Highlights

  • Holiday Animation: Introduces a festive snow animation and holiday tree ASCII art to the Gemini CLI header.
  • Conditional Activation: The holiday features are enabled only during December and January, when the "Holiday" theme is active, the terminal width is sufficient, and no chat session has begun.
  • New useSnowfall Hook: A new React hook, useSnowfall, was added to manage the animation logic and integrate holiday-themed ASCII art.
  • Test Coverage: New tests were added to Header.test.tsx to verify the rendering of holiday colors and trees during the holiday season.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@thejackluo
Copy link

This is awesome

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a holiday-themed snow animation. My review focuses on a logic bug in date checking, issues with the new tests that will cause them to fail, and a performance concern in the animation rendering loop. These issues are of high severity and should be addressed to ensure the feature works correctly and efficiently.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Size Change: +3.76 kB (+0.02%)

Total Size: 22 MB

Filename Size Change
./bundle/gemini.js 22 MB +3.76 kB (+0.02%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@sehoon38 sehoon38 marked this pull request as ready for review December 23, 2025 22:42
@sehoon38 sehoon38 requested a review from a team as a code owner December 23, 2025 22:42
@sehoon38 sehoon38 changed the title feat: Gemini CLI Happy Holiday feat: Gemini CLI show holiday animation Dec 23, 2025
@sehoon38 sehoon38 changed the title feat: Gemini CLI show holiday animation feat: Show holiday animation Dec 23, 2025
@sehoon38 sehoon38 changed the title feat: Show holiday animation feat: Show snowfall animation for holiday theme Dec 23, 2025
@sehoon38 sehoon38 added this pull request to the merge queue Dec 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2025
@sehoon38 sehoon38 added this pull request to the merge queue Dec 26, 2025
Merged via the queue into main with commit 9cdb267 Dec 26, 2025
32 of 33 checks passed
@sehoon38 sehoon38 deleted the sehoon/holiday branch December 26, 2025 16:22
@galz10
Copy link
Collaborator

galz10 commented Dec 26, 2025

/patch both

@github-actions
Copy link

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: stable,preview
  • Commit: 9cdb267ba5869b48bdfca9079e22b526fd757b3f
  • Workflows Created: 2

🔗 Track Progress:

github-actions bot pushed a commit that referenced this pull request Dec 26, 2025
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
@github-actions
Copy link

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. Review and approve the hotfix PR: #15591
  2. Once merged, the patch release will automatically trigger
  3. You'll receive updates here when the release completes

🔗 Track Progress:

github-actions bot pushed a commit that referenced this pull request Dec 26, 2025
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
@github-actions
Copy link

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. Review and approve the hotfix PR: #15592
  2. Once merged, the patch release will automatically trigger
  3. You'll receive updates here when the release completes

🔗 Track Progress:

@github-actions
Copy link

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: stable → publishing to npm tag latest
  • Version: v0.22.2
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.22.2-pr-15494

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions
Copy link

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: preview → publishing to npm tag preview
  • Version: v0.23.0-preview.1
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.23.0-preview.1-pr-15494

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions
Copy link

Patch Release Complete!

📦 Release Details:

  • Version: 0.22.3
  • NPM Tag: latest
  • Channel: stable
  • Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

@github-actions
Copy link

Patch Release Complete!

📦 Release Details:

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants