-
Notifications
You must be signed in to change notification settings - Fork 10.2k
feat: add github colorblind themes #15504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Z1xus, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's accessibility by integrating two new colorblind-friendly themes. These themes, 'GitHub Dark Colorblind' and 'GitHub Light Colorblind,' are specifically tailored to assist users with protanopia and deuteranopia, ensuring a more inclusive user experience by providing optimized color palettes for code highlighting and UI elements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two new colorblind-friendly themes, 'GitHub Dark Colorblind' and 'GitHub Light Colorblind', which is a great accessibility improvement. The implementation is correct, and the new themes are properly registered. My main feedback is about significant code duplication between the two new theme files. I've suggested a refactoring approach using a factory function to centralize the theme structure, which will improve long-term maintainability.
Summary
adds github dark colorblind and github light colorblind themes to improve accessibility for users with protanopia and deuteranopia
Related Issues
closes #15503
Details
colors taken from github's primer design system
How to Validate
after building start the cli and switch themes in settings to Github Dark Colorblind and Github Light Colorblind
Pre-Merge Checklist