feat(core,cli): relocate clipboard images to project-specific temp dir #15527
Conversation
Moves clipboard image storage from the project root to to keep the workspace clean. - Update Storage to generate project-specific temporary paths. - Register the clipboard directory in WorkspaceContext to ensure access in sandboxed environments. - Refactor Config initialization to inject the clipboard path directly into the context. - Update to use absolute paths for pasted images.
Summary of ChangesHello @psinha40898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how temporary clipboard images are managed, moving them from a project-local Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of clipboard images by relocating the temporary directory from within the project folder to a project-specific directory in ~/.gemini/tmp/. This is a great improvement as it avoids the need for users to add this temporary path to their .gitignore. While the changes are generally good for security and workspace management, a high-severity command injection vulnerability was identified in the saveClipboardImage function on macOS. The file path is not properly sanitized before being used in an AppleScript command, which could allow for arbitrary code execution if a user operates in a maliciously named directory. Specific details and recommendations are provided in the review comments. Otherwise, the implementation is clean and effectively addresses the stated problem, with key changes including a new getProjectClipboardDir() method, earlier Storage service initialization, and updates to saveClipboardImage and cleanupOldClipboardImages utilities, all covered by updated tests.
| export async function saveClipboardImage( | ||
| targetDir?: string, | ||
| storage: Storage, | ||
| ): Promise<string | null> { |
There was a problem hiding this comment.
The saveClipboardImage function is vulnerable to command injection on macOS. The tempFilePath variable, which is derived from the project's root directory path (storage.getProjectClipboardDir()), is used to construct an AppleScript command without proper escaping. If a user runs the CLI in a directory with a specially crafted name containing double quotes, they can inject arbitrary AppleScript, which can in turn execute shell commands. For example, a directory named my\"project & do shell script \"touch /tmp/pwned\" would allow command execution.
There was a problem hiding this comment.
Not introduced in this PR
1 participant
Summary
Currently pasting images creates a temporary directory inside the project which requires users to add that path to .gitignore
This PR has the temporary directory live inside
~/.gemini/tmp/${project_hash}/It treats that path as valid in the workspace
Details
By deliberately adding this path as part of the "workspace" it should work as intended including for all sandbox modes
Related Issues
Fixes #15453
How to Validate
Pre-Merge Checklist