Skip to content

Conversation

@oodenough
Copy link

Summary

Fix recursive .env loading to prevent local files from obscuring global configuration (e.g., ~/.gemini/.env).

Details

  • Modified findEnvFiles to recursively search parent directories up to home.
  • Switched to multiple .env file loading with override: false to allow inheritance.
  • Fixed authentication issues by ensuring global credentials are not obscured by local .env.

Related Issues

Fixes #14688
Fixes #13840

How to Validate

  • Modified findEnvFiles to recursively search parent directories up to home.
  • Switched to multiple .env file loading with override: false to allow inheritance.
  • Fixed authentication issues by ensuring global credentials are not obscured by local .env.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@oodenough oodenough requested a review from a team as a code owner December 25, 2025 08:55
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @oodenough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where local .env files could inadvertently override or obscure global configuration settings, leading to authentication failures. By modifying the environment loading mechanism, the system now recursively discovers all relevant .env files from the current working directory up to the user's home directory. These files are then loaded in a way that allows for proper inheritance, ensuring that global configurations are respected and local settings only augment or refine them without causing conflicts.

Highlights

  • Recursive .env loading: The system now recursively searches parent directories up to the user's home directory for .env files, including ~/.gemini/.env.
  • .env file inheritance: Multiple .env files are now loaded with override: false, ensuring that global configurations are not obscured by local settings and allowing for proper inheritance.
  • Authentication fix: This change resolves authentication issues by correctly prioritizing global credentials over local .env variables, preventing unintended overrides.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements recursive loading of .env files, enabling hierarchical configuration and inheritance of global settings, by changing findEnvFile to findEnvFiles and loading multiple files with override: false. While no specific security vulnerabilities were identified in the general review, a bug was found in the new findEnvFiles function that can lead to duplicate .env file paths from the home directory. Suggestions have been provided to fix this using a Set for deduplication.

…ration

This change ensures that .env files are loaded from the current directory up to the user's home directory, allowing global configurations (like ~/.gemini/.env) to be respected even when a local .env file exists.

Fixes google-gemini#14688
Fixes google-gemini#13840
@oodenough oodenough force-pushed the fix/recursive-env-loading branch from 4474c1a to 39513c2 Compare December 25, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discovery Error: GitHub Connection Failed due to Bad Authorization Header Authentication with github mcp server fails

1 participant