Skip to content

Conversation

@matbrito
Copy link

@matbrito matbrito commented Sep 8, 2025

Add support do worker pool. Some considerations of this PR are placed below:

  • Worker pool only exists in alpha and beta gcloud components.
  • There is no region flag when using replace command (metadata) in worker pool. Official documentation

@steren
Copy link
Contributor

steren commented Oct 9, 2025

Thanks for the PR. I'm supportive of adding worker pool (assuming it has been added on the same model as jobs)

We are looking for someone at Google to review the PR

Copy link
Member

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.

@iennae iennae changed the title Worker Pool support feat(run): adds Worker Pool support to deploy-cloudrun action Oct 10, 2025
@matbrito
Copy link
Author

@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.

Hi @iennae, thanks for your initial review, i've just made some code changes related to the comments you left. I'm totally open to new comments and suggestions

@iennae
Copy link
Member

iennae commented Oct 15, 2025

@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here!

@bai
Copy link

bai commented Oct 24, 2025

A friendly bump just in case it fell through the cracks - supporting this would be awesome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants