Add protobuf sources to support building outside of cocoapods #19
+5,036
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.0.0 added a dependency on protobuf, and updated the podspec to declare this, but didn't update the xcodeproj itself. This broke Carthage support and prevents building from a clone of the repo.
This change:
protobufsubmodule checked out atv3.14.0protobuf.xcodeprojby runningcmake -G Xcode -T buildsystem=1 -DCMAKE_OSX_SYSROOT=iphoneos -DCMAKE_OSX_ARCHITECTURES='$(ARCHS_STANDARD)' -DCMAKE_OSX_DEPLOYMENT_TARGET=11.1 protobuf/cmakebuildsystem=1: uses the legacy build system. protobuf specifies dependencies in such a way that cmake can't generate using the modern build systemCMAKE_OSX_SYSROOT=iphoneos: builds protobuf using the iOS SDKCMAKE_OSX_ARCHITECTURES='$(ARCHS_STANDARD)': prevents cmake from settings ONLY_ACTIVE_ARCHS=NO, which causes simulator release builds of GTXiLib to failCMAKE_OSX_DEPLOYMENT_TARGET=11.1: matches the GTXiLib's deployment targetGTXiLib.xcworkspacewhich includes both projectsTesting done:
No target application path specified via test configurationpod spec lint .fails, but it also fails on master. not sure whether there's an issue in the podspec, or if it's something on my end?carthage build --use-xcframeworks --no-skip-currentsucceeds