Add async and await support to DaysUntilBirthday Swift sample app #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you rebase this branch against |
mdmathias
force-pushed
the
mdmathias/async-support
branch
from
c485819 to
b82ac43
Compare
Collaborator
Author
|
Yep! Sorry about that. |
petea
suggested changes
Aug 3, 2022
Samples/Swift/DaysUntilBirthday/DaysUntilBirthday.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Services/BirthdayLoader.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/macOS/DaysUntilBirthdayOnMac.entitlements
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/AuthenticationViewModel.swift
Outdated
Show resolved
Hide resolved
mdmathias
force-pushed
the
mdmathias/async-support
branch
from
b82ac43 to
0bb46ee
Compare
This was referenced Aug 5, 2022
mdmathias
force-pushed
the
mdmathias/async-support
branch
from
0bb46ee to
db1677e
Compare
petea
approved these changes
Aug 6, 2022
Contributor
petea
left a comment
petea
left a comment
There was a problem hiding this comment.
Looks good. Discussed offline and agreed that we would wait to merge into main until we're closer to shipping Swift Concurrency support.
Alex-4-Git
approved these changes
Aug 11, 2022
petea
force-pushed
the
mdmathias/async-support
branch
from
14368a9 to
a75b5ab
Compare
Contributor
|
@mdmathias this is now in sync with |
petea
force-pushed
the
mdmathias/async-support
branch
from
36fb2dd to
d0deb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.