[Infra] Fix flaky 'NSURLSession+GULPromises' test (approach 2)#120
Closed
[Infra] Fix flaky 'NSURLSession+GULPromises' test (approach 2)#120
Conversation
Member
Author
|
Hmm, that's weird, |
Coverage Report 1Affected Products
Test Logs |
Member
Author
|
Pausing investigation into the crash. Weirdly, the promise timeout in this PR and in #119 is the same. The crash can be more easily produced by running the tests on Catalyst (via CocoaPods) and enabling the address sanitizer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another approach to #119 that I think is probably better.
Some context, the test crashes are originating in tests that test our category on NSURLSession. We use OCMock to stub the behavior of the underlying NSURLSession. Rather than using OCMock, I figured we could use the real NSURLSession, and instead make local requests on file system URLs. This approach seems to actually work well and wasn't difficult to set up.
Fixes CI failures in PRs like #110 and #118