feat(database): allow passing a db connection to the session service

[NotNahid]

This change modifies the NewSessionService function to accept a *gorm.DB object directly, instead of creating a new one. This allows for sharing a single database connection across multiple services.

The AutoMigrate function has also been updated to accept a *gorm.DB object directly.

Fixes #340

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @NotNahid, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the database session service to allow for greater flexibility in managing database connections. By modifying NewSessionService and AutoMigrate to accept an already established *gorm.DB instance, the system can now share a single database connection across various services. This change simplifies the API, removes internal connection management from the service, and enhances resource efficiency by preventing redundant database connections.

Highlights

• NewSessionService Function Signature Change: The NewSessionService function in session/database/service.go now directly accepts a *gorm.DB object instead of a gorm.Dialector and gorm.Option values. This means the database connection is expected to be opened externally and passed in.
• AutoMigrate Function Signature Change: The AutoMigrate function in session/database/service.go has been updated to directly accept a *gorm.DB object. This change removes the previous requirement for a type assertion on the session.Service interface, simplifying its usage and removing potential runtime errors.
• Database Connection Sharing: These changes enable the sharing of a single *gorm.DB connection across multiple services, promoting better resource management and potentially reducing connection overhead.
• Test Suite Updates: The emptyService helper function in session/database/service_test.go has been refactored to align with the new function signatures, now explicitly opening the GORM database connection before passing it to NewSessionService and AutoMigrate.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors NewSessionService and AutoMigrate to accept a *gorm.DB connection directly, which is a good practice for managing database connections and allows for sharing a single connection across services. The implementation is clean and the tests are properly updated. I have a suggestion to further refine the API of NewSessionService for better clarity and consistency.

[gemini-code-assist]

Since NewSessionService no longer creates the database connection itself, it can't fail. The function signature can be simplified to return only session.Service instead of (session.Service, error). This makes the API cleaner and more ergonomic for callers, as they won't need to handle a nil error. This change would also align with the function's comment, which already states that it returns a [session.Service].

Suggested change

	func NewSessionService(db *gorm.DB) (session.Service, error) {
	return &databaseService{db: db}, nil
	}
	func NewSessionService(db *gorm.DB) session.Service {
	return &databaseService{db: db}
	}

[gemini-code-assist]

To align with the suggested change of NewSessionService returning a single value (the service, not an error), this call site should be updated. The error handling is no longer necessary.

Suggested change

	service, err := NewSessionService(db)
	if err != nil {
	t.Fatalf("Failed to create session service: %v", err)
	}
	service := NewSessionService(db)