Introduce Config type for adkrest

[Kenasvarghese]

This PR introduces a Config type in the adkrest package to define
session, artifact, and agent dependencies.

As a follow-up to #415, adkrest should not directly depend on
launcher.Config. Defining a package-local configuration type provides
a clearer and more appropriate abstraction for REST integration.

Related issue: #418

[gemini-code-assist]

Summary of Changes

Hello @Kenasvarghese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the configuration management within the adkrest package by introducing a dedicated Config type. This change aims to improve modularity and reduce tight coupling by ensuring the adkrest package manages its own dependencies (session, artifact, agent services) through a specific interface, rather than relying on a broader launcher.Config.

Highlights

• New Configuration Type: Introduced a new Config type within the adkrest package to explicitly define its required dependencies, such as session, artifact, and agent services.
• Dependency Decoupling: Decoupled the adkrest package from directly depending on launcher.Config, addressing a follow-up from issue Move restapi server controllers and routers to internal #415.
• Improved Abstraction: The new package-local Config type provides a clearer and more appropriate abstraction for managing dependencies specific to REST integration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a dedicated Config type for the adkrest package, successfully decoupling it from launcher.Config. This is an excellent change that improves modularity and clarifies the dependencies for the REST integration. The implementation is clean, correct, and effectively isolates the configuration needed by adkrest. No issues were found in the implementation.

[rakyll]

LGTM, cc @mazas-google @dpasiukevich to approve the breaking change.

[IAmSurajBobade]

@Kenasvarghese can you fix adkrest example. https://github.com/google/adk-go/blob/main/examples/rest/main.go#L69

[Kenasvarghese]

Please Review @IAmSurajBobade

[Kenasvarghese]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a Config type for the adkrest package, successfully decoupling it from launcher.Config. The changes are well-implemented across the modified files, including updating the NewHandler function and its call sites. My main feedback is regarding the example in examples/rest/main.go, which appears to be missing the initialization for ArtifactService, potentially leading to runtime errors. I've provided a suggestion to address this.

[Kenasvarghese]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively refactors the adkrest package to use its own Config type, successfully decoupling it from launcher.Config. This is a solid improvement for code modularity and clarity. My review focuses on enhancing the robustness of this new configuration by adding validation to prevent potential runtime panics from nil dependencies. The suggestions include adding a Validate method to the new Config struct, updating NewHandler to perform validation and return an error, and adjusting the call sites accordingly.

[Kenasvarghese]

@rakyll @IAmSurajBobade @dpasiukevich Do I need to implement validation and error for the config