Move internal/context into the agent package

[git-hulk]

This tries to resolve the issue mentioned in #391.

[gemini-code-assist]

Summary of Changes

Hello @git-hulk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the application's context management by migrating key context-related types from an internal package to the more public agent package. This change aims to enhance modularity, improve accessibility, and streamline the creation and usage of invocation and callback contexts throughout the system. The refactoring involved creating new context files within the agent package, updating existing agent logic to leverage these new public constructors, and adjusting all dependent modules and test files to align with the revised package structure, ultimately addressing issue #391.

Highlights

• Context Type Relocation: The core context types, invocationContext, callbackContext, and readonlyContext, have been moved from the internal/context package to the agent package. This makes these context structures publicly accessible within the agent package.
• New Context Constructors: New public constructors like NewInvocationContextFromParams, NewWrappedInvocationContext, NewCallbackContext, and NewReadonlyContext have been introduced in the agent package to facilitate the creation and management of these context types.
• Refactored Agent Logic: The agent/agent.go file has been updated to utilize these new public constructors and to access EventActions from callbackContext via a dedicated getter method, improving encapsulation.
• Widespread Codebase Updates: Numerous files across the codebase, including various test files and agent implementations (e.g., llmagent, remoteagent, workflowagents), have been updated to remove imports from the now-removed internal/context package and instead import and use the context types and constructors from the agent package.
• Improved Context Handling in Utilities: Utility functions, such as util/instructionutil/instruction.go, now use agent.GetInvocationContextFromReadonly for safer and more explicit casting of ReadonlyContext to InvocationContext.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors context-related types and their factory functions by moving InvocationContext, CallbackContext, and ReadonlyContext from the internal/context package to the public agent package. New files agent/callback_context.go, agent/invocation_context.go, and agent/readonly_context.go were introduced, and the corresponding internal/context files were deleted. All call sites across the codebase were updated to use the new public agent package context functions, such as agent.NewInvocationContextFromParams, agent.NewCallbackContext, and agent.NewReadonlyContext. Additionally, the callbackContext now includes an internalArtifacts wrapper that tracks artifact saves by updating session.EventActions.ArtifactDelta, and a GetEventActions method was added to expose these actions. A review comment highlighted a potential race condition in internalArtifacts.Save where concurrent artifact saves with the same name could lead to data inconsistency due to the lack of a locking mechanism for ia.eventActions.ArtifactDelta.