Respect ADK_DISABLE_LOAD_DOTENV across all usages of load_dotenv_for_agent

[Spikhalskiy]

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: Respect ADK_DISABLE_LOAD_DOTENV across the project #4018
• Related: Disable forced .env loading #3228

Problem:
15afbcd implemented an environment variable that would stop ADK from loading agent .env files. It did it in cli.py only, while more places load .env files

Solution:

All usages of load_dotenv_for_agent are not under the ADK_DISABLE_LOAD_DOTENV check.

Testing Plan

I did not; the change is pretty trivial and should not call the load_dotenv_for_agent if the corresponding environment variable is supplied.

Unit Tests:

Original contribution 15afbcd was not covered by tests, so I assumed they were not needed for this change.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

[gemini-code-assist]

Summary of Changes

Hello @Spikhalskiy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in how the ADK_DISABLE_LOAD_DOTENV environment variable is respected. Previously, despite the variable being set, .env files might still be loaded in certain parts of the application. This change ensures that the environment variable is universally honored, providing developers with reliable control over .env file loading for agents across various operational contexts.

Highlights

• Consistent Environment Variable Handling: The ADK_DISABLE_LOAD_DOTENV environment variable, intended to prevent the loading of agent .env files, was previously only effective in cli.py. This pull request extends its enforcement to all locations where load_dotenv_for_agent is called, ensuring consistent behavior across the application.
• Wider Application of Disable Flag: The is_env_enabled('ADK_DISABLE_LOAD_DOTENV') check has been integrated into adk_web_server.py, cli_tools_click.py, fast_api.py, service_registry.py, and agent_loader.py to prevent unintended .env file loading.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly applies the ADK_DISABLE_LOAD_DOTENV check to all usages of load_dotenv_for_agent, ensuring consistent behavior across the application. The changes are straightforward and address the issue described. However, I strongly recommend adding unit tests for this change. While the original feature may not have had tests, adding them now would significantly improve the robustness of this functionality and prevent future regressions. Simple unit tests could be added to verify that load_dotenv_for_agent is called or skipped based on the environment variable. I've also left a comment about using a constant for the environment variable name to improve maintainability.

[gemini-code-assist]

The magic string 'ADK_DISABLE_LOAD_DOTENV' is used in multiple files across this pull request. To improve maintainability and prevent potential typos in the future, it would be best to define this as a constant in a shared module (for example, in src/google/adk/utils/env_utils.py alongside is_env_enabled) and import it where needed.

[adk-bot]

Response from ADK Triaging Agent

Hello @Spikhalskiy, thank you for your contribution!

I've noticed that this PR does not include unit tests. As per our contribution guidelines, all code changes should include tests to ensure the quality and prevent regressions. Could you please add unit tests for your changes?

This will help us to review and merge your PR more efficiently. Thanks!