fix: ensure interrupted signal is emitted when flushing text in GeminiLlmConnection

[vonhutuan-b3]

Description

A bug was identified in GeminiLlmConnection.receive where the interrupted signal was lost if there was accumulated text that needed to be flushed. This PR removes the else block in the interruption handling to ensure the interrupted signal is always yielded after flushing any pending text.

Proposed Changes

• Modified src/google/adk/models/gemini_llm_connection.py to always yield LlmResponse(interrupted=True) when an interruption signal is received from the server.

Testing Plan

• Verified with a standalone reproduction script that simulates a partial text followed by an interruption signal.
• Ran existing unit tests: uv run --extra test pytest tests/unittests/models/test_gemini_llm_connection.py (all 23 passed).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the GeminiLlmConnection that prevented the interrupted signal from being reliably propagated when streaming responses from the Gemini LLM. The fix ensures that even if partial text has been accumulated, the interruption signal is correctly sent, improving the robustness of real-time interaction handling and preventing lost signals.

Highlights

• Bug Fix: Interrupted Signal Handling: Resolved an issue in GeminiLlmConnection.receive where the interrupted signal was not consistently emitted if there was pending text to flush, by ensuring the signal is always yielded after any accumulated text.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/google/adk/models/gemini_llm_connection.py
  • Modified the receive method to always yield LlmResponse(interrupted=True) when an interruption signal is received, regardless of whether text was flushed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @vonhutuan-b3, thank you for creating this PR!

This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one?

This information will help reviewers to review your PR more efficiently. Thanks!

[gemini-code-assist]

Code Review

This pull request correctly addresses a bug where an interrupted signal could be lost when flushing pending text. The change ensures the signal is always emitted. However, my review identifies a potential side effect of this change: in cases where an interruption message also contains model content, the interrupted signal may be emitted twice. I've provided a suggestion to prevent this redundant signaling and ensure the client receives a clean, single interruption event.