Port virtio media simple device as a vhost user media device. #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port virtio media reference device `simple_device` as a vhost user implementation. First iteration of `simple_device/src/simple_device.rs` is the same as in virtio-media upstream https://github.com/chromeos/virtio-media/blob/main/device/src/devices/simple_device.rs. ``` cargo run --bin simple_device -- --socket-path /tmp/simple_device.sock ``` ``` cargo run --features "media" -- --log-level=debug run --cpus 4 --mem 4096 \ --rwdisk /path/to/debian-12.img \ --params "root=/dev/vda1" \ --vhost-user media,socket=/tmp/simple_device.sock \ /path/to/bzImage v4l2-compliance -d0 -s ``` Bug: 445229097
Member
Why are you copying this code here instead of depending on it? Would it be possible to contribute changes upstream and only implement the cuttlefish-specific changes here? |
jemoreira
reviewed
Dec 16, 2025
Member
There was a problem hiding this comment.
You should add bazel files too
Databean
reviewed
Dec 16, 2025
Comment on lines
+1
to
+4
| //! Simple example virtio-media CAPTURE device with no dependency. | ||
| //! | ||
| //! This module illustrates how to write a device for virtio-media. It exposes a capture device | ||
| //! that generates a RGB pattern on the buffers queued by the guest. |
Member
There was a problem hiding this comment.
The original file has a license declaration, that has to be maintained if you want to copy the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port virtio media reference device
simple_deviceas a vhost user implementation.First iteration of
simple_device/src/simple_device.rsis the same as in virtio-media upstream https://github.com/chromeos/virtio-media/blob/main/device/src/devices/simple_device.rs.Bug: 445229097