Skip to content

Conversation

@LZRS
Copy link
Collaborator

@LZRS LZRS commented Jan 6, 2026

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
A fix to prevent crash that occurs when the QuestionnaireItemViewFactory.Content composable is used without wrapping the composable in QuestionnaireTheme

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS requested a review from a team as a code owner January 6, 2026 15:23
@LZRS LZRS requested review from jingtang10 and removed request for a team January 6, 2026 15:23
val LocalQuestionnaireDimensions = staticCompositionLocalOf { QuestionnaireDimensions() }
val LocalQuestionnaireShapes = staticCompositionLocalOf { QuestionnaireShapes() }
val LocalQuestionnaireTextStyles =
staticCompositionLocalOf<QuestionnaireTextStyles> { error("No QuestionnaireTextStyles provided") }
Copy link
Collaborator Author

@LZRS LZRS Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error thrown here is removed and replaced with a default QuestionnaireTextStyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

1 participant