Fix LLVM githash check failure on buildbots #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"git log --format=%h" does not always give the 12-hex long githash, this causes githash check failure. Fixed by using "git log --format=%H" which gives the full githash, and only compare the first 12 hex numbers to the predefined githash. Tested by running this both on the buildbot and on workstations.
snehasish
reviewed
Jul 17, 2024
Collaborator
snehasish
left a comment
snehasish
left a comment
There was a problem hiding this comment.
I saw the same issue in my draft PR which adds a basic CI. I'll rebase my changes on this if you want to get this in sooner or I can fix it when I push my changes.
If you do want to go ahead with this, can you use the full hash instead of taking a substring, it should be "e4f9175d23950ecaef32db075ed47dafe3be555c".
Collaborator
Author
|
I see. Either way should be fine. |
Collaborator
|
Ok, lets hold on to this and I'll rebase and send out my changes for review by the end of the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"git log --format=%h" does not always give the 12-hex long githash, this causes githash check failure.
Fixed by using "git log --format=%H" which gives the full githash, and only compare the first 12 hex numbers to the predefined githash.
Tested by running this both on the buildbot and on workstations.