Skip to content

Use STL containers when requiring pointer/iterator stability #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use STL containers when requiring pointer/iterator stability #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion differ.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace security::bindiff {
class MatchingContext;

// These need to be sorted
using Histogram = absl::btree_map<std::string, size_t>;
using Histogram = std::map<std::string, size_t>;
using Confidences = absl::btree_map<std::string, double>;

// Main entry point to the differ, runs the core algorithm and produces a
Expand Down
4 changes: 2 additions & 2 deletions reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ struct FlowGraphInfo {
int edge_count = 0;
int instruction_count = 0;
};
using FlowGraphInfos = absl::btree_map<Address, FlowGraphInfo>;
using FlowGraphInfos = std::map<Address, FlowGraphInfo>;

struct FixedPointInfo {
friend bool operator==(const FixedPointInfo& lhs, const FixedPointInfo& rhs) {
Expand Down Expand Up @@ -69,7 +69,7 @@ struct FixedPointInfo {
bool evaluate;
bool comments_ported;
};
using FixedPointInfos = absl::btree_set<FixedPointInfo>;
using FixedPointInfos = std::set<FixedPointInfo>;

bool operator<(const FixedPointInfo& one, const FixedPointInfo& two);

Expand Down