Skip to content

Fix build without IDA #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build without IDA #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ cmake -S . -B build/out -G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=build/out \
-DBINDIFF_BINEXPORT_DIR=build/binexport \
-DBINEXPORT_ENABLE_IDAPRO=OFF
-DBINEXPORT_ENABLE_IDAPRO=OFF \
-DBINDIFF_ENABLE_IDAPRO=OFF
```

### Java GUI and yFiles
Expand Down
4 changes: 3 additions & 1 deletion cmake/BinDiffDeps.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ if(NOT sqlite_POPULATED)
endif()

# Setup IDA SDK. Uses FindIdaSdk.cmake from BinExport
find_package(IdaSdk)
if(BINDIFF_ENABLE_IDAPRO)
find_package(IdaSdk)
endif()

find_package(Protobuf 3.14 REQUIRED) # Make protobuf_generate_cpp available
2 changes: 2 additions & 0 deletions cmake/BinDiffOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ option(BINDIFF_BUILD_TESTING
"If ON, this will build all of BinDiff's own tests" ${BINDIFF_TOP_LEVEL})
option(BINDIFF_BUILD_BENCHMARK
"If this and BINDIFF_BUILD_TESTING is ON, build benchmark tests" OFF)
option(BINDIFF_ENABLE_IDAPRO
"If ON, enable building the IDA Pro plugin" ON)

if(BINDIFF_BUILD_TESTING)
# Have BinExport download GoogleTest/Benchmark for us
Expand Down