IDA: Fix ida(64) executable detection. #162
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 7e92f6a commit added a condition that checks the
IDA_SDK_VERSION, which is not actually defined for thebinexport_sharedtarget (that buildsutil/idb_export.cc).https://github.com/google/binexport/blob/main/util/idb_export.cc#L61-L74
I forgot about this being an issue until now, because it has just materialized on a fresh installation of IDA. At one point, I've symlinked
idatoida64locally to work around that issue 😆 (and I assume authors of previous pull requests did something similar).Since
IdbExporteris also used by thebindiffcommand line tool, I've figured that the best approach would be implementing executable detection, as I don't know of any other sane way to determine the IDA version (idatdoesn't seem to have--versionswitch or anything...). If there's a better way to approach this, I welcome suggestions.