-
Notifications
You must be signed in to change notification settings - Fork 38
Deploy docker image wrapping cloud orchestrator #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8337878 to
1b0d150
Compare
|
@ser-io PTAL. HDYT about wrapping CO with docker? Would it be the way we should go, as you mentioned in the mail thread? |
Thanks for sending this out. Yes, I think it's better to package the CO service into a Docker image for on-premises deployment. I'm still working on the design. |
ser-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rephrase the story of this PR.
To do so we need to be clear about containerizing the CO service vs CO as a Docker Instance Manager.
-
The code under
scripts/dockeris to run the CO as a Docker Instance Manager, we shouldn't modify this code just yet. -
Under a new
deployments/directory we create the tools/scripts to containerize the CO service, you cannot have a fixedconf.tomlhere, you need to pass one. -
Back to
scripts/docker, here you can reuse the work in step 2 if you prefer to run a docker container rather than building and running the binary on your own. You can publish artifacts of this specific docker image, but let's don't this just yet.
Understood. As a following question, would GCP case be using containerized CO in the future? @ser-io |
|
Converting this into draft again, since previous review was to get folks' opinions initially & now it's iterating for writing better code. |
2196156 to
f1c998a
Compare
|
This PR would be paused until sharing design doc from Sergio. |
9b3f8ab to
1ee3310
Compare
|
After merging this PR, we would be able to deploy Cloud Orchestrator via Artifact Registry. |
1ee3310 to
d1694ee
Compare
ikicha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @ser-io might want to review this PR as well.
d1694ee to
74e0cdf
Compare
74e0cdf to
1d07a22
Compare
1d07a22 to
9b86875
Compare
8277698 to
eb213b9
Compare
eb213b9 to
01afe78
Compare
01afe78 to
d42f4ec
Compare
No description provided.