Skip to content

Conversation

@0405ysj
Copy link
Collaborator

@0405ysj 0405ysj commented Aug 30, 2024

No description provided.

@0405ysj 0405ysj changed the title Co with docker Deploy docker image wrapping cloud orchestrator Aug 30, 2024
@0405ysj 0405ysj marked this pull request as ready for review August 30, 2024 05:08
@0405ysj 0405ysj requested review from ikicha and removed request for Databean, adelva1984, jemoreira, jmacnak and rmuthiah August 30, 2024 05:08
@0405ysj
Copy link
Collaborator Author

0405ysj commented Aug 30, 2024

@ser-io PTAL. HDYT about wrapping CO with docker? Would it be the way we should go, as you mentioned in the mail thread?

@ser-io
Copy link
Member

ser-io commented Aug 30, 2024

@ser-io PTAL. HDYT about wrapping CO with docker? Would it be the way we should go, as you mentioned in the mail thread?

Thanks for sending this out. Yes, I think it's better to package the CO service into a Docker image for on-premises deployment. I'm still working on the design.

Copy link
Member

@ser-io ser-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rephrase the story of this PR.

To do so we need to be clear about containerizing the CO service vs CO as a Docker Instance Manager.

  1. The code under scripts/docker is to run the CO as a Docker Instance Manager, we shouldn't modify this code just yet.

  2. Under a new deployments/ directory we create the tools/scripts to containerize the CO service, you cannot have a fixed conf.toml here, you need to pass one.

  3. Back to scripts/docker, here you can reuse the work in step 2 if you prefer to run a docker container rather than building and running the binary on your own. You can publish artifacts of this specific docker image, but let's don't this just yet.

@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 2, 2024

To do so we need to be clear about containerizing the CO service vs CO as a Docker Instance Manager.

Understood. As a following question, would GCP case be using containerized CO in the future? @ser-io

@0405ysj 0405ysj marked this pull request as draft September 2, 2024 05:33
@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 2, 2024

Converting this into draft again, since previous review was to get folks' opinions initially & now it's iterating for writing better code.

@0405ysj 0405ysj force-pushed the co_with_docker branch 3 times, most recently from 2196156 to f1c998a Compare September 2, 2024 07:14
@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 4, 2024

This PR would be paused until sharing design doc from Sergio.

@0405ysj 0405ysj marked this pull request as ready for review December 11, 2024 03:44
@0405ysj 0405ysj requested review from ikicha and ser-io December 11, 2024 03:44
@0405ysj
Copy link
Collaborator Author

0405ysj commented Dec 11, 2024

After merging this PR, we would be able to deploy Cloud Orchestrator via Artifact Registry.

Copy link
Collaborator

@ikicha ikicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @ser-io might want to review this PR as well.

@0405ysj 0405ysj requested a review from ser-io December 13, 2024 02:30
@0405ysj 0405ysj force-pushed the co_with_docker branch 2 times, most recently from 8277698 to eb213b9 Compare December 20, 2024 01:04
@0405ysj 0405ysj added this pull request to the merge queue Dec 21, 2024
Merged via the queue into google:main with commit 534a394 Dec 21, 2024
5 checks passed
@0405ysj 0405ysj deleted the co_with_docker branch December 21, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants