Return error on ADB connection failure #455
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great project.
While exploring codebase, I found some suspicious behaviors related to err handling and resource closing , therefore I opened PR.
First issue related to err handling @ runConnectionWebSocketAgentCommand & runConnectionWebrtcAgentCommand
I think code below do not exit when adb connect is failed.
Should we
return errwhen adb connect failed? or is this intended ?Second issue related to resource closing @ runConnectionWebSocketAgentCommand
I think code below do not close the
net.Listenresource.Should we add
defer l.Close()?Thank you for taking time for reading my small fix.