Skip to content

Internal-only change #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Internal-only change #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rs_bindings_from_cc/generate_bindings/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ rust_library(
"//common:error_report",
"//common:ffi_types",
"//rs_bindings_from_cc/generate_bindings/database",
"@crate_index//:tracing", # v0_1
],
)

Expand Down
1 change: 1 addition & 0 deletions rs_bindings_from_cc/generate_bindings/cc_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ pub unsafe extern "C" fn GenerateBindingsImpl(
let rustfmt_config_path: OsString =
std::str::from_utf8(rustfmt_config_path.as_slice()).unwrap().into();
catch_unwind(|| {

let error_report: Option<ErrorReport>;
let errors: &dyn ErrorReporting = if generate_error_report {
error_report = Some(ErrorReport::new());
Expand Down