Skip to content

elevate PMP and VLV to the global namespace #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cstirdivant wants to merge 4 commits into from
Closed

elevate PMP and VLV to the global namespace #1330

cstirdivant wants to merge 4 commits into from

Conversation

@cstirdivant
Copy link
Contributor

@cstirdivant cstirdivant commented May 2, 2024 •
edited
Loading

Elevating PMP and VLV general types to the global namespace

  • removing namespace-level defs for PMP and VLV from HVAC and PLUMBING
  • revising canonical types to inherit from the global namespace
  • removing un-used non-canonical types in HVAC/PMP.yaml

@shambersafai shambersafai mentioned this pull request Dec 29, 2025
Merged
@shambersafai
Copy link
Member

shambersafai commented Dec 29, 2025

missing CLA, recreated in #1669

@shambersafai shambersafai deleted the gps-global-elevation branch December 29, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tasodorff tasodorff Awaiting requested review from tasodorff

@shambersafai shambersafai Awaiting requested review from shambersafai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cstirdivant @shambersafai