Allow include directive in python generator with gen-onefile #8675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
jwidauer
force-pushed
the
allow-includes-with-gen-onefile
branch
from
30fc450 to
bccef4f
Compare
|
Closing in favor of #8710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8543, by generating import statements when a foreign definition (a definition that was not defined in the file currently being parsed) is encountered.
As well as using the
def->declaration_file, instead of thedef->file, when available, to create the import statement. This is done, since thedef->filefilename will have an absolute path in certain cases, whereas thedef->declaration_filedoes not.Please let me know if there is anything you'd like me to change or if there's anything wrong with my logic.