Fix --gen-compare to not generate comparators for native types. #8681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
cosmith-nvidia
force-pushed
the
native-type-compare
branch
2 times, most recently
from
0f75a6a to
97d087a
Compare
Contributor
Author
|
@dbaileychess I rebased this onto master and also added the --gen-compare flag to the CMakeLists.txt compile_schema_for_test (now the one-off without comparator is no longer needed!). PTAL. Thanks! |
cosmith-nvidia
force-pushed
the
native-type-compare
branch
2 times, most recently
from
0230452 to
e6469d1
Compare
Per the definition of --gen-compare: only generate comparators for object API generated structs. Types annoated with native_type must define their own comparators if `--gen-compare` is enabled. Also enables --gen-compare for native_type_test and fixes the test by adding a comparator for the Native::Vector3D type.
cosmith-nvidia
force-pushed
the
native-type-compare
branch
from
e6469d1 to
f01cf2e
Compare
aardappel
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the definition of --gen-compare: only generate comparators for object API generated structs. Types annoated with native_type must define their own comparators if
--gen-compareis enabled.Also enables --gen-compare for native_type_test and fixes the test by adding a comparator for the Native::Vector3D type.