Improve retrieval of properties from LOI documents #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@rfontanarosa Is this draft PR still valid / working? |
Collaborator
Author
yes, but i have to add the changes merged in master. I'll do it once this (#2249) will be approved. |
rfontanarosa
changed the title
# Conflicts: # functions/src/export-csv.ts
gino-m
reviewed
Nov 21, 2025
gino-m
requested changes
Nov 21, 2025
| if (!(ownerIdFilter ? loi[9] === 2 && loi[5] === ownerIdFilter : true)) | ||
| return; | ||
| if (ownerIdFilter) { | ||
| if (!(loi[9] === 2 && loi[5] === ownerIdFilter)) { |
Collaborator
There was a problem hiding this comment.
Do we have named constants we can refer to field numbers instead of using literals?
| const loi = doc.data(); | ||
| if (!(ownerIdFilter ? loi[9] === 2 && loi[5] === ownerIdFilter : true)) | ||
| return; | ||
| if (ownerIdFilter) { |
Collaborator
There was a problem hiding this comment.
Also, I think this is still a bit confusing.. maybe we want something like this:
if (canViewAll || loiOwnerId === userId) {
return extractLoiProperties(loi);
} else {
return undefined;
}Then we don't need ownerIdFilter at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.