Open
Conversation
This detects the problem of #7769. To actually merge this, I'd want to: - Make it work with the version of Gradle we already use, 8.5, or else upgrade the somewhat-standard version of Gradle that's used across a handful of Google project, including ours. - Integrate it into our CI and release processes, including testing with the version that we're building, as [in our Gradle integration tests for our module metadata](https://github.com/google/guava/blob/97c96e00bd8940b45399979cbd4162d3ef362532/integration-tests/gradle/build.gradle.kts#L1). - Put some patterns into a `.gitignore` file here, similar to [what we already have for the previous Gradle integration tests](https://github.com/google/guava/blob/master/integration-tests/gradle/.gitignore).
cpovirk
force-pushed
the
agp-integration-test
branch
from
3eb1c42 to
7e41f72
Compare
copybara-service bot
pushed a commit
to android/android-test
that referenced
this pull request
Jul 21, 2025
For this purpose, I temporarily resurrected [`update_gradle.sh`](http://google3/third_party/gradle/update_gradle.sh;rcl=775340930), and I left a couple notes in cl/761102714. I somewhat expect for this upgrade to break someone after submission (when a system like Kokoro runs tests). (TGP is clean, but I doubt that it offers significant test coverage.) I'm happy to roll back if there are issues; I'd just like to _attempt_ an upgrade so that we get some idea of what kind of testing a future upgrade might need and so that I record the existence of the `update_gradle.sh` script for anyone who might need it in the future. (I may or may not undelete it after this CL.) (If this CL does stick, it will be a step toward merging google/guava#7775.) PiperOrigin-RevId: 785527343
Member
Author
|
(I'd ideally also want to not make our CI take significantly longer than it already does, as tracked in internal issue 334979149.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects the problem of #7769.
To actually merge this, I'd want to:
Make it work with the version of Gradle we already use, 8.5, or else
upgrade the somewhat-standard version of Gradle that's used across a
handful of Google project, including ours.
Integrate it into our CI and release processes, including testing with
the version that we're building, as in our Gradle integration tests
for our module
metadata.
Put some patterns into a
.gitignorefile here, similar to what wealready have for the previous Gradle integration
tests.