testlib: Add ConcurrentMapSpliteratorTester for spliterator characteristics #8173
+169
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ConcurrentMapSpliteratorTesterto verify spliterator characteristics onConcurrentMapviewsentrySet(),keySet(), andvalues()spliterators have theCONCURRENTcharacteristicCONCURRENTandSIZEDcharacteristics (mutually incompatible per Java spec)Motivation
Per issue #7855 and maintainer guidance from @chaoren:
ConcurrentMapimplementations should return spliterators with theCONCURRENTcharacteristicCONCURRENTandSIZEDCurrently, some Guava
ConcurrentMapimplementations (e.g.,LocalCache,MapMakerInternalMap) return spliterators that:CONCURRENT(should have it)SIZED(should not have it for concurrent collections)This PR adds tests to document the expected behavior. A follow-up PR can fix the implementations.
Testing
ConcurrentMap*Testerpattern in testlibConcurrentHashMapcorrectly returnsCONCURRENT=true, SIZED=falseRelated Issues
Fixes #7855