Lists.transform: Preserve spliterator characteristics from backing list #8176
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spliterator()inTransformingSequentialListandTransformingRandomAccessListCollectSpliterators.map()Motivation
Lists.transform()withCopyOnWriteArrayListthrowsConcurrentModificationExceptionduring parallel stream operations because the defaultAbstractList.spliterator()doesn't inherit theIMMUTABLEcharacteristic from the backing list.Before:
Lists.transform(cowList, fn).parallelStream()→ CMEAfter: Characteristics preserved, no CME
Implementation
Follows the exact pattern used in
Collections2.TransformedCollection.spliterator():Testing
ListsTest: 5,999 tests passedCollections2Test: 1,300 tests passedCollectSpliteratorsTest: 7 tests passedCopyOnWriteArrayListconcurrent stress testFixes #8165