ImmutableBiMap: Mark GWT inverse field as transient for GWT-RPC #8177
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inverse field in GWT's RegularImmutableBiMap was not marked as transient, causing GWT-RPC serialization warnings about circular references. This aligns the GWT version with the main guava and android versions, which already have transient on this field. Fixes google#8168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
inversefield in GWT'sRegularImmutableBiMapastransienttransient)Motivation
GWT-RPC generates warnings when a Map is used in an RPC service interface because the
inversefield creates a circular reference that GWT-RPC attempts to serialize. The field should be markedtransientsince:inverse()transientfor this fieldFixes #8168
Testing