Maps: Avoid double iteration in uniqueIndex for FilteredCollection#8197
Open
nickita-khylkouski wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Skip pre-sizing optimization when input is FilteredCollection or FilteredMultimapValues, as their size() methods iterate through all elements, causing double iteration when combined with the subsequent uniqueIndex iteration. Fixes google#6638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maps.uniqueIndexwhen input isFilteredCollectionorFilteredMultimapValuessize()methodsMotivation
Maps.uniqueIndexcallssize()onCollectioninputs to pre-size the builder. However,FilteredCollection.size()andFilteredMultimapValues.size()iterate through all elements applying the predicate. This causes the predicate to be evaluated twice:size()callThis fix skips the pre-sizing optimization for these filtered views, avoiding the double iteration.
Fixes #6638
Testing