Skip to content

Conversation

@zaccharieramzi
Copy link
Contributor

@zaccharieramzi zaccharieramzi commented Sep 10, 2023

WIP: need to run the existing tests and add the previously failing test written by @vroulet in a previous PR

In order to implement this change, I had to change the dtype of gamma which is now a pytree rather than a scalar, since it can be different for each leaf of the parameters.

@zaccharieramzi
Copy link
Contributor Author

So actually the failure that @vroulet was showcasing here is actually already a test in the broyden test suite.

Everything is green now (with simpler settings), so this is ready for review.

@zaccharieramzi zaccharieramzi marked this pull request as ready for review December 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant