Skip to content

Conversation

@davidmorgan
Copy link
Collaborator

@davidmorgan davidmorgan commented Oct 21, 2025

Thinking about using the new(ish) "triggers" feature in json_serializable, it actually turns out it doesn't work yet because json_serializable is strict about its options :)

dart-lang/build#4254 (reply in thread)

This allows the option, but does not actually use it (yet). People can then enable it in their own build.yaml.

@davidmorgan davidmorgan marked this pull request as ready for review October 21, 2025 16:03
@davidmorgan davidmorgan requested a review from kevmoo October 21, 2025 16:03
@kevmoo
Copy link
Collaborator

kevmoo commented Oct 21, 2025

Is this ready to review or just FYI for now?

@davidmorgan
Copy link
Collaborator Author

davidmorgan commented Oct 22, 2025

I think it's good to go like this, it's already useful even if released without actually using triggers, because it lets users turn them on. Thanks!

@davidmorgan davidmorgan merged commit 3c09ab4 into google:master Oct 23, 2025
18 checks passed
@davidmorgan davidmorgan deleted the triggers-workaround branch October 23, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants