marshal empty properties map as empty object #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some MCP clients want a "properties" keyword on a tool schema, even if it is empty. For an example, see golang/go#76777. This PR makes an empty map in Schema.Properties marshal as "{}" instead of omitting it. Technically, this is a breaking change, but it is extremely unlikely that it will matter to anyone (except in a good way).
baptmont
approved these changes
Dec 18, 2025
jba
added a commit
that referenced
this pull request
Dec 19, 2025
manusa
added a commit
to containers/kubernetes-mcp-server
that referenced
this pull request
Dec 22, 2025
The marshaling of empty properties to an empty JSON object was fixed: - google/jsonschema-go#59 - google/jsonschema-go#60 Released in https://github.com/google/jsonschema-go/releases/tag/v0.4.2 Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
added a commit
to containers/kubernetes-mcp-server
that referenced
this pull request
Dec 22, 2025
The marshaling of empty properties to an empty JSON object was fixed: - google/jsonschema-go#59 - google/jsonschema-go#60 Released in https://github.com/google/jsonschema-go/releases/tag/v0.4.2 Signed-off-by: Marc Nuri <marc@marcnuri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MCP clients want a "properties" keyword on a tool schema, even if it is empty.
For an example, see golang/go#76777.
This PR makes an empty map in Schema.Properties marshal as "{}" instead of omitting it.
Technically, this is a breaking change, but it is extremely unlikely that it will matter to anyone (except in a good way).