python: Automated pre-release checks before publishing #1185
+371
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyammer
force-pushed
the
py-build-release-gha
branch
19 times, most recently
from
842a8ee to
63b072a
Compare
- add pre-release-checks, gated by release tags - run package checks on the actual artifacts (i.e., the packages), and not just from the source of the repo. - add stub for actual release - simplify "uv add magika" linux vs. windows, using shell: bash - make uv version easily updatable
In GH actions, the "path" filter is not used for tags push. This means that any tag push would trigger this gh action, even if the push has nothing to do with it. Fixed by triggering only for branch pushes to main (note: the branch filter is used for tags as well), and for any PR that relates to this.
…ot needed if we don't do that, the build-wheels and other jobs will not run as the pre-release-checks is a dependency.
reyammer
force-pushed
the
py-build-release-gha
branch
from
781cc4d to
a34f78c
Compare
reyammer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, python releases started with a GH release being created, and have involved a bunch of manual checks, e.g., check that the version in the git tag matches the version of the package, check that the version of the package is a non-dev one, check that the version of the underlying rusr CLI is a non-dev one, etc. And then, we would manually upload the wheels ourselves.
The new plan is to start releases via a push of a git tag of the form
python-vX.Y.Z. If the GH action is triggered from a such a tag, we also perform a number of pre-release checks before building and testing the packages, and after we have all the wheels we would publish to pypi.This PR implements all the pre-release checks we want, and the logic to trigger them in "strict mode" only when release tags are pushed.
There is also an initial stub for publishing to pypitest, but that's not complete. For now we keep this as-is, because it seems we need the gh action workflow on github to experiment with the trusted publisher thingy.
Fixes #948.
Fixes #1004.
Fixes #1041.