Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Dec 11, 2025

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an internal _time feature to measure inference time in the Rust CLI. The implementation is mostly correct, but I've found a critical issue in how the average inference time is calculated, which leads to an incorrect metric. I've also identified a potential division-by-zero error and a minor style issue. My review includes suggestions to fix these issues to ensure the feature provides accurate measurements and the code is robust and idiomatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant