-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Free up lots of disk space to avoid out of disk space errors. Fixes #1942 #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I agree on #1 - I originally tried the more aggressive docker prune and
when that failed to free enough space I asked Gemini for suggestions - I
imagined we would not want to do all of these so I left those size comments
in for discussion and we could see what the savings was.
Originally I was able to free 3% more, and that was not enough. We now
free more than enough (like 30%) and we could remove several. I will
remove `hosttoolcache` - probably just android would be enough honestly.
The sparse checkout also sounds good, I did not want to change any of
those parts of the script. Breaking this repo up also sounds good as it's
huge and slow to checkout...
…On Wed, Oct 8, 2025, 4:24 PM Brendan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/main.yml
<#1943 (comment)>
:
> + echo "Removing large hosted tool caches (~8 GB total)"
+ sudo rm -rf /opt/hostedtoolcache
1. Hard-coding the expected size savings (~8 GB total) in a prompt may
become misleading in the future.
2. Removing the /opt/hostedtoolcache will cause actions/setup-python
<https://github.com/actions/setup-python> to become slower because it
initially tries to use a cached version of python in this directory. See
the current list of cached tools on ubuntu-24.04 runner
<https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#cached-tools>.
By removing /opt/hostedtoolcache, you force actions/setup-python
<https://github.com/actions/setup-python> to download Python from
actions/python-versions <https://github.com/actions/python-versions>.
This is ill-advised, unless you specifying a specific patch version of
python. Below in this workflow the current desired version is a minor
version
python-version: 3.11# BTW, this should be a string ('3.11' with quotes), not a float (without quotes)# '3.11.13' would be a patch version
—
Reply to this email directly, view it on GitHub
<#1943 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3YUSOZL6FC7S3JCEH44ED3WWMLDAVCNFSM6AAAAACIVO6LBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJWG44DQNZUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
YuzeHao2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@YuzeHao2023 Thanks! @EsoFromTheEast / @tphinney It would be awesome to get this merged so we can new fonts - it's been quite a while now ( Last successful run was Sep 18, 2025 ) |
dvlan26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Just wanted to add a ping to remind everyone that we this repo has not produced fonts fonts for over 3 months now. My branch at https://github.com/timmaffett/material-design-icons/ has been using this PR for months and has been producing fonts as it should. I have been using my repo for the release of the Flutter version of the Material Symbols Icons, but I would prefer to go back to using the official repo. There are now almost 200 new icons that have been added to the set which are not available in this official repo's fonts. @tphinney @EsoFromTheEast Any chance we can merge this before Thursday's action runs ? Thanks everyone and Happy Holidays! |
Two weeks ago our
main.ymlaction stopped working because of out of disk space errors.This change to
.github/workflows/main,ymlmore aggressively frees up disk space by deleting unused tools that are never needed by the update symbols process. We use only python so this is script removes tools such java and android sdks which are never needed. The disk space is reported before and after cleanup and we go from 70% used to 42% used - freeing plenty of space to avoid the error that is now preventingmain.ymlfrom working.Excerpt from run on my copy of repo using this change (and where
main.ymlworks again):Details of run here
(Editing to reflect current version of script only removing Android and .NET SDKs)