Skip to content

Delay get version in AppBundleBuilder.cs #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thaina wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Delay get version in AppBundleBuilder.cs #161

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f0132e9
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
02f4938
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
3bb1bd0
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
a5a1a9f
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
dfa89de
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
f8b3c42
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
c7c95cf
Update AppBundleBuilder.cs
Thaina Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...ugins/com.google.android.appbundle/Editor/Scripts/Internal/BuildTools/AppBundleBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ public virtual bool Initialize(BuildToolLogger buildToolLogger)
// Cache information that is only accessible from the main thread.
_minSdkVersion = PlayerSettings.Android.minSdkVersion;
_packageName = PlayerSettings.GetApplicationIdentifier(BuildTargetGroup.Android);
_versionCode = PlayerSettings.Android.bundleVersionCode;
_versionName = PlayerSettings.bundleVersion;

_assetPackManifestTransformers = AssetPackManifestTransformerRegistry.Registry.ConstructInstances();
var initializedManifestTransformers = true;
Expand Down Expand Up @@ -176,7 +174,12 @@ public virtual AndroidBuildResult BuildAndroidPlayer(BuildPlayerOptions buildPla
};

// Do not use BuildAndSign since this signature won't be used.
return _androidBuilder.Build(updatedBuildPlayerOptions);
var buildResult = _androidBuilder.Build(updatedBuildPlayerOptions);

_versionCode = PlayerSettings.Android.bundleVersionCode;
_versionName = PlayerSettings.bundleVersion;

return buildResult;
}

/// <summary>
Expand Down Expand Up @@ -888,4 +891,4 @@ private string DisplayBuildError(string errorType, string errorMessage)
return _buildErrorMessage;
}
}
}
}