Skip to content

Fixed symbol zip file not being moved with Unity 2022, include non-batch mode build support. #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trapezoid wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed symbol zip file not being moved with Unity 2022, include non-batch mode build support. #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef02390
apply patch https://github.com/google/play-unity-plugins/pull/226
Feb 19, 2024
2b5d6db
cache PlayerSettings.GetScriptingBackend for access from sub threads
Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ugins/com.google.android.appbundle/Editor/Scripts/Internal/BuildTools/AppBundleBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ private enum BuildStatus
private string _packageName;
private int _versionCode;
private string _versionName;
private ScriptingImplementation _scriptingBackend;
private PostBuildCallback _createBundleAsyncOnSuccess = delegate { };
private IEnumerable<IAssetPackManifestTransformer> _assetPackManifestTransformers;

Expand Down Expand Up @@ -119,6 +120,7 @@ public virtual bool Initialize(BuildToolLogger buildToolLogger)
_packageName = PlayerSettings.GetApplicationIdentifier(BuildTargetGroup.Android);
_versionCode = PlayerSettings.Android.bundleVersionCode;
_versionName = PlayerSettings.bundleVersion;
_scriptingBackend = PlayerSettings.GetScriptingBackend(BuildTargetGroup.Android);

_assetPackManifestTransformers = AssetPackManifestTransformerRegistry.Registry.ConstructInstances();
var initializedManifestTransformers = true;
Expand Down Expand Up @@ -760,7 +762,12 @@ private void MoveSymbolsZipFile(string aabFilePath)

private string GetSymbolsFileName(string prefix)
{
#if UNITY_2022_1_OR_NEWER
// Unity 2022 started adding the scripting backend to the symbol zip's name
return string.Format("{0}-{1}-v{2}-{3}.symbols.zip", prefix, _versionName, _versionCode, _scriptingBackend);
#else
return string.Format("{0}-{1}-v{2}.symbols.zip", prefix, _versionName, _versionCode);
#endif
}

private static void CopyFilesRecursively(DirectoryInfo sourceDirectory, DirectoryInfo destinationDirectory)
Expand Down