Skip to content

Fix Python 3.9 and 3.10 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Python 3.9 and 3.10 #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pyglove/core/typing/type_conversion_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
import calendar
import datetime
import sys
import typing
import unittest

Expand Down Expand Up @@ -130,12 +131,16 @@ def test_int_to_float(self):
def test_datetime_to_int(self):
"""Test built-in converter between int and datetime.datetime."""
timestamp = calendar.timegm(datetime.datetime.now().timetuple())
now = datetime.datetime.fromtimestamp(timestamp, datetime.UTC)
if sys.version_info >= (3, 11):
now = datetime.datetime.fromtimestamp(timestamp, datetime.UTC)
else:
now = datetime.datetime.utcfromtimestamp(timestamp)
self.assertEqual(vs.Object(datetime.datetime).apply(timestamp), now)
self.assertEqual(vs.Int().apply(now), timestamp)
self.assertEqual(
type_conversion.get_json_value_converter(datetime.datetime)(now),
timestamp)
timestamp
)

def test_keypath_to_str(self):
"""Test built-in converter between string and KeyPath."""
Expand Down