Some fixes for Zephyr testing #39

dsseng · 2025-06-19T14:16:10Z

Generate compile_commands.json from Bazel
Remove unsupported commands from the feature mask

hchataing · 2025-06-20T15:48:13Z

Thank you for the changes :)

ISO communications are still rather broken, couldn't get BAP server to actually function.

Can you elaborate on this ? We did not have a lot of testing done on this part and I am not surprised that issues remain.
Just so you know, I recently fixed some issues with ACL disconnection, I will upload the changes next week.

hchataing · 2025-06-20T15:38:13Z

model/controller/dual_mode_controller.cc

         OpCodeIndex::READ_AUTHENTICATED_PAYLOAD_TIMEOUT},
-        {OpCode::WRITE_AUTHENTICATED_PAYLOAD_TIMEOUT,
-         OpCodeIndex::WRITE_AUTHENTICATED_PAYLOAD_TIMEOUT},
+        // {OpCode::WRITE_AUTHENTICATED_PAYLOAD_TIMEOUT,


This is not the right place to disable the command; there are two options (aside from fixing the implementation...):

in the list of hci_command_handlers_ below (but rootcanal will assert if the command is invoked)

in the controller properties model/controller/controller_properties.h, in the supported command mask

I've got no clear understanding of this command from reading Zephyr and other open source code. I'm not a SIG member (you probably are via Google), so I only use implementations as reference.

Disabled it the good way now

packets/hci_packets.pdl

hchataing · 2025-06-20T15:46:29Z

model/controller/dual_mode_controller.cc

          kNumCommandPackets, ErrorCode::SUCCESS));
 }

+void DualModeController::SetControllerToHostFlowControl(CommandView command) {


Can I ask you to implement host flow control ?
If you only added the command because zephyr was invoking it, another option would be to remove the command Set Controller to Host Flow Control from the supported command mask in the controller properties.

I found that I should just apply the same CONFIG_BT_HCI_ACL_FLOW_CONTROL=n as for Android NetSim (supposedly the same Rootcanal?) to the samples. Discarded that commit now

Will make sure I document it when I write a doc for running Zephyr with Rootcanal for Zephyr docs

I think removing it from supported_commands (here's the ID: https://github.com/google/bumble/blob/cce2e4d4e3238d8aa65e4ee2eefe2f13ab7f8dc0/bumble/hci.py#L1007) should also be done: no reason to report unsupported command as supported (or is it for Android or other bt stack that wants it supported but won't call?)

hchataing · 2025-06-25T20:17:56Z

#40 syncs with AOSP and brings some ISO fixes.

Make clangd work

dsseng · 2025-07-23T19:36:33Z

#40 syncs with AOSP and brings some ISO fixes.

Thank you! Rebased and now more examples work!

Remove some unsupported commands which confuse Zephyr samples and cause them to run into assertions. Sync status from model/controller/dual_mode_controller.cc to model/controller/controller_properties.cc, to prevent host sending commands that make controller assert.

dsseng · 2025-07-23T20:26:09Z

Okay, thanks for pointing me in the right direction and sorry for a long wait, I synchronized the command list to avoid misreporting those as supported. Now Zephyr warns me to set proper options: [00:00:00.200,000] <wrn> bt_hci_core: Controller to host flow control not supported

Please review if any of those disable actions break anything on your side. My help however is limited here, as I am a student learning BLE, and not a SIG member, so I only have limited information

Here's the diff of supported commands (received by Bumble), most of them seem to already say No in the readme:

Details

10d9
<   HCI_ENABLE_DEVICE_UNDER_TEST_MODE_COMMAND
16d14
<   HCI_FLUSH_COMMAND
19d16
<   HCI_HOST_NUMBER_OF_COMPLETED_PACKETS_COMMAND
48d44
<   HCI_LE_READ_CHANNEL_MAP_COMMAND
61d56
<   HCI_LE_READ_RF_PATH_COMPENSATION_COMMAND
64d58
<   HCI_LE_RECEIVER_TEST_COMMAND
91d84
<   HCI_LE_SET_HOST_CHANNEL_CLASSIFICATION_COMMAND
104,106d96
<   HCI_LE_TEST_END_COMMAND
<   HCI_LE_TRANSMITTER_TEST_COMMAND
<   HCI_LE_WRITE_RF_PATH_COMPENSATION_COMMAND
114,116d103
<   HCI_READ_AFH_CHANNEL_ASSESSMENT_MODE_COMMAND
<   HCI_READ_AFH_CHANNEL_MAP_COMMAND
<   HCI_READ_AUTHENTICATED_PAYLOAD_TIMEOUT_COMMAND
118d104
<   HCI_READ_AUTOMATIC_FLUSH_TIMEOUT_COMMAND
128d113
<   HCI_READ_EXTENDED_INQUIRY_RESPONSE_COMMAND
130d114
<   HCI_READ_HOLD_MODE_ACTIVITY_COMMAND
135d118
<   HCI_READ_LE_HOST_SUPPORT_COMMAND
137,138d119
<   HCI_READ_LINK_SUPERVISION_TIMEOUT_COMMAND
<   HCI_READ_LMP_HANDLE_COMMAND
156,157d136
<   HCI_READ_SECURE_CONNECTIONS_HOST_SUPPORT_COMMAND
<   HCI_READ_SIMPLE_PAIRING_MODE_COMMAND
172d150
<   HCI_SET_AFH_HOST_CHANNEL_CLASSIFICATION_COMMAND
174d151
<   HCI_SET_CONTROLLER_TO_HOST_FLOW_CONTROL_COMMAND
178c155
<   HCI_SETUP_SYNCHRONOUS_CONNECTION_COMMAND
---
>   HCI_SET_MIN_ENCRYPTION_KEY_SIZE_COMMAND
186,187d162
<   HCI_WRITE_AFH_CHANNEL_ASSESSMENT_MODE_COMMAND
<   HCI_WRITE_AUTHENTICATED_PAYLOAD_TIMEOUT_COMMAND
189d163
<   HCI_WRITE_AUTOMATIC_FLUSH_TIMEOUT_COMMAND
195d168
<   HCI_WRITE_HOLD_MODE_ACTIVITY_COMMAND
199d171
<   HCI_WRITE_INQUIRY_TRANSMIT_POWER_LEVEL_COMMAND
210,211d181
<   HCI_WRITE_SECURE_CONNECTIONS_TEST_MODE_COMMAND
<   HCI_WRITE_SIMPLE_PAIRING_DEBUG_MODE_COMMAND

dsseng · 2025-07-23T20:52:20Z

Now I can connect Zephyr BAP server, as well as simpler devices like heart rate sensor (also running on native-sim) to my host computer and audio devices work with PipeWire now!

In many cases you want your devices to find connection strong enough and not avoid connecting

hchataing · 2025-07-28T11:14:40Z

Thank you for the update !

To clarify the situation with supported HCI commands:
A distinction is made between the list of commands that appear in the supported command mask, and the list of actually implemented commands. This is so that RootCanal can properly emulate different controller configurations. The mask in controller_properties.cc defines the default value for the HCI supported command mask. It does enable commands that are not implemented as you have discovered. They were left enabled as a way to discover commands that are used by various host stacks as priority targets for feature expansion (we don't have the resources to implement every single command).

hchataing · 2025-07-28T11:02:43Z

model/setup/test_model.cc

+};
+
+std::unique_ptr<PhyLayer> TestModel::CreatePhyLayer(PhyLayer::Identifier id, Phy::Type type, Phy::Model model) {
+  if (model == Phy::Model::IDEAL) {


Could you use a switch case preferably ?

hchataing · 2025-07-28T11:04:36Z

model/controller/controller_properties.cc

          OpCodeIndex::READ_REMOTE_SUPPORTED_FEATURES, OpCodeIndex::READ_REMOTE_EXTENDED_FEATURES,
          OpCodeIndex::READ_REMOTE_VERSION_INFORMATION, OpCodeIndex::READ_CLOCK_OFFSET,
-          OpCodeIndex::READ_LMP_HANDLE, OpCodeIndex::SETUP_SYNCHRONOUS_CONNECTION,
+          // OpCodeIndex::READ_LMP_HANDLE, OpCodeIndex::SETUP_SYNCHRONOUS_CONNECTION,


Careful, SETUP_SYNCHRONOUS_CONNECTION is implemented.

hchataing · 2025-07-28T11:08:32Z

include/phy.h

    BR_EDR,
  };
+
+  enum class Model {


PathLossModel ?

hchataing self-assigned this Jun 20, 2025

hchataing reviewed Jun 20, 2025

View reviewed changes

Generate compile_commands.json from Bazel

ea841f7

Make clangd work

dsseng force-pushed the zephyr-fixes branch from 4106194 to 9d8f787 Compare July 23, 2025 20:04

dsseng force-pushed the zephyr-fixes branch from 9d8f787 to 9ecec71 Compare July 23, 2025 20:18

fixup! Generate compile_commands.json from Bazel

1bd59f0

dsseng requested a review from hchataing July 23, 2025 20:31

dsseng added 2 commits July 24, 2025 11:02

Add an ideal PHY model and make it the default

20ba9b4

In many cases you want your devices to find connection strong enough and not avoid connecting

fixup! Add an ideal PHY model and make it the default

f4c97c2

dsseng mentioned this pull request Jul 24, 2025

Make randomness predictable #41

Open

hchataing reviewed Jul 28, 2025

View reviewed changes

Some fixes for Zephyr testing #39

Are you sure you want to change the base?

Some fixes for Zephyr testing #39

Uh oh!

Conversation

dsseng commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hchataing commented Jun 20, 2025

Uh oh!

hchataing Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

dsseng Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hchataing Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

dsseng Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

dsseng Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hchataing commented Jun 25, 2025

Uh oh!

dsseng commented Jul 23, 2025

Uh oh!

dsseng commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsseng commented Jul 23, 2025

Uh oh!

hchataing commented Jul 28, 2025

Uh oh!

hchataing Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

hchataing Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

hchataing Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dsseng commented Jun 19, 2025 •

edited

Loading

dsseng Jul 23, 2025 •

edited

Loading

dsseng commented Jul 23, 2025 •

edited

Loading