upgrade slo-generator version, python version and add arm build.#316
Open
dirtyren wants to merge 8 commits intogoogle:masterfrom
Open
upgrade slo-generator version, python version and add arm build.#316dirtyren wants to merge 8 commits intogoogle:masterfrom
dirtyren wants to merge 8 commits intogoogle:masterfrom
Conversation
dirtyren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to prometheus increase errors, some time a shorter window will have more bad events than a longer window, which should no happen and will generate a invalid SLI. When this happens, we discard the calculation for the shorter window.
The patch also reuse the backend data if window is the same, when we have the same window doing calculations for different burning rates