Included additional metrics to be exposed. Only 6/7 metrics are being exposed if I am using the promethues as a backend and the pushgateway as an exporter.#493
Open
ppothepa24 wants to merge 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Hi @ppothepa24, I will take a look later this week. I have a lot on my plate right now, and find myself unable to spend as much time as I'd like on the SLO Generator. |
Contributor
|
I replied in #490 (reply in thread). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made changes to the files in base.py and report.py to ensure that additional metrics namely (error_budget_target, error_budget_measurement, error_budget_burn_rate, error_budget_remaining_minutes, error_budget_minutes etc) be exposed. But i am not sure if these changes are actually being compiled and executed as the changes in the source code arent reflecting in the output.